Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsapi/dns_desec.sh remove DEDYN_NAME variable #3505

Merged
merged 2 commits into from
May 8, 2021

Conversation

willbrowningme
Copy link
Contributor

This pull request removes the unnecessary DEDYN_NAME variable from the dns_desec.sh file.

The $_domain variable is used instead which is already retrieved from the _get_root function.

See this comment for more details.

Essentially a duplicate of this previous pull request that sent to master - #3063

@Neilpang
Copy link
Member

Neilpang commented May 8, 2021

Thanks, please update the doc too:

https://github.com/acmesh-official/acme.sh/wiki/dnsapi#71-use-desecio

@Neilpang Neilpang merged commit 461f602 into acmesh-official:dev May 8, 2021
@willbrowningme
Copy link
Contributor Author

Thanks, just updated the docs!

daniel-beet pushed a commit to daniel-beet/acme.sh.wiki-clone that referenced this pull request May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants