Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CleverReach Deploy API #3132

Merged
merged 5 commits into from
Nov 29, 2020
Merged

Conversation

jpbede
Copy link
Contributor

@jpbede jpbede commented Aug 28, 2020

This PR is adding the ability to deploy a certificate and key to a CleverReach account.

@jpbede
Copy link
Contributor Author

jpbede commented Oct 28, 2020

Any news ? :)

deploy/cleverreach.sh Outdated Show resolved Hide resolved
deploy/cleverreach.sh Outdated Show resolved Hide resolved
@jpbede
Copy link
Contributor Author

jpbede commented Oct 28, 2020

Didn't expect that quick and a big thank you for the review :)

Have fixed your annotations.

@jpbede jpbede requested a review from Neilpang November 4, 2020 07:28
@Neilpang
Copy link
Member

did you add the usage here ?
https://github.com/acmesh-official/acme.sh/wiki/deployhooks

@jpbede
Copy link
Contributor Author

jpbede commented Nov 29, 2020

No, i waited for the merge. I've added it now.

@Neilpang
Copy link
Member

did you create a new issue for bug reporting?

Example: #2977

@jpbede
Copy link
Contributor Author

jpbede commented Nov 29, 2020

#3276

@Neilpang Neilpang merged commit be06746 into acmesh-official:dev Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants