Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RackSpace DNS API only returns 100 domains at a time when you use the "list domains" endpoint. This can cause the _get_root_zone() function to falsely return the "invalid domain" error. #2944

Closed
ianw opened this issue May 18, 2020 · 0 comments

Comments

@ianw
Copy link
Contributor

ianw commented May 18, 2020

The RackSpace DNS API only returns 100 domains at a time when you use the "list domains" endpoint. This can cause the _get_root_zone() function to falsely return the "invalid domain" error.

I recommend using the "domain search" endpoint instead: https://developer.rackspace.com/docs/cloud-dns/v1/api-reference/domains/#search-domains

If you change line 97 as follows it works nicely for accounts with hundreds of domains:
if ! _rackspace_rest GET "$RACKSPACE_Tenant/domains/search?name=$h"; then

Originally posted by @jjamfd in #2091 (comment)

ianw added a commit to ianw/acme.sh that referenced this issue May 18, 2020
The current call uses the /domains end-point which lists all domains.
This only returns 100 domains at a time, so for long domain lists you
may not match and find the required ID.

Switch to using the search interface that only returns values matching
the requested domain.  This will avoid missing results.

Closes: acmesh-official#2944
@acmesh-official acmesh-official deleted a comment from auto-comment bot May 19, 2020
honzahommer pushed a commit to honzahommer/acme.sh that referenced this issue Jul 10, 2020
The current call uses the /domains end-point which lists all domains.
This only returns 100 domains at a time, so for long domain lists you
may not match and find the required ID.

Switch to using the search interface that only returns values matching
the requested domain.  This will avoid missing results.

Reported by @jjamfd.

Closes: acmesh-official#2944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant