2021 ACIS FP recalibration (for real this time) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
approved these changes
Sep 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a re-do of PR #32, which had the incorrect JSON file in it. The rest of these comments are identical to what was written there.
This recalibration of the ACIS FP model was first introduced at the TWG on 7/8/2021 and approved at the TWG on 7/22/2021.
This PR simply updates the JSON file which is part of the
acisfp_checkpackage and does not change any software.Details of the recalibration can be found here: sot/chandra_models#76
Testing