Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new FP limits #74

Merged
merged 4 commits into from
May 20, 2024
Merged

Support new FP limits #74

merged 4 commits into from
May 20, 2024

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented May 20, 2024

Description

The acis_thermal_check regression testing interface is here updated to support the new ACIS FP science data quality limits implemented in https://github.com/sot/chandra_limits/pull/15. The new limits are added to the test model spec JSON file and the answers are updated, which involve the obsids table and the violation test answers. No model outputs are expected to change, nor have they.

Interface impacts

None

Testing

Need chandra_models 3.53

Unit tests

  • Mac

Independent check of unit tests by Jean

  • Linux:
In [2]: acis_thermal_check.test('-k acisfp or dpa')
================================================================ test session starts =================================================================
platform linux -- Python 3.11.8, pytest-7.4.4, pluggy-1.4.0
rootdir: /proj/sot/ska/jeanproj/git/acis_thermal_check
configfile: pytest.ini
plugins: anyio-4.3.0, timeout-2.2.0
collected 355 items / 250 deselected / 105 selected

acis_thermal_check/tests/acisfp/test_acisfp_acis.py ........................                                                                   [ 22%]
acis_thermal_check/tests/acisfp/test_acisfp_acis_obsids.py ...                                                                                 [ 25%]
acis_thermal_check/tests/acisfp/test_acisfp_kadi.py ........................                                                                   [ 48%]
acis_thermal_check/tests/acisfp/test_acisfp_viols.py ....                                                                                      [ 52%]
acis_thermal_check/tests/dpa/test_dpa_acis.py ........................                                                                         [ 75%]
acis_thermal_check/tests/dpa/test_dpa_kadi.py ........................                                                                         [ 98%]
acis_thermal_check/tests/dpa/test_dpa_valid_only.py .                                                                                          [ 99%]
acis_thermal_check/tests/dpa/test_dpa_viols.py .                                                                                               [100%]

================================================================== warnings summary

Functional tests

No functional testing.

Copy link
Contributor

@Gregg140 Gregg140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

Copy link

@jeanconn jeanconn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that the tests that we run for Ska integration pass now so LGTM.

@jeanconn jeanconn mentioned this pull request May 20, 2024
@jzuhone jzuhone merged commit 3c58515 into master May 20, 2024
1 check passed
@javierggt javierggt mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants