Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ALC256 layout-id for Hasee X57S1 with 4CH by Ardentwheel #613

Closed
wants to merge 1 commit into from

Conversation

Ardentwheel
Copy link

@Ardentwheel Ardentwheel commented Oct 13, 2020

Fixed Ice Lake-LP HDAController
Thanks for @zhen-zen, @fewtarius and @m0d16l14n1

#601 (comment)

@ghost
Copy link

ghost commented Oct 13, 2020

The Ice Lake controller change needs additional testing before merging, it was only verified to work on one laptop model. It should be OK'ed by @zhen-zen before merging as well. Also pinging @lvs1974 for credit as the original author of the patch.

@Ardentwheel, you should consider separating the controller patch from your layout PR.

@Ardentwheel
Copy link
Author

The Ice Lake controller change needs additional testing before merging, it was only verified to work on one laptop model. It should be OK'ed by @zhen-zen before merging as well. Also pinging @lvs1974 for credit as the original author of the patch.

@Ardentwheel, you should consider separating the controller patch from your layout PR.

oK, I do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant