Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay in available page #1449

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Overlay in available page #1449

wants to merge 7 commits into from

Conversation

natacha-beck
Copy link
Contributor

This PR replace #t1440

@MontrealSergiy
Copy link
Contributor

MontrealSergiy commented Dec 3, 2024

would be nice to summarize the solution (UI change) in a few words

Copy link
Contributor

@MontrealSergiy MontrealSergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nicer.

@@ -41,7 +41,10 @@
end
%>
<tr>
<td><%= overlay_description((name + "\n" + description).strip) %></td>
<td>
<%= name %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have name in both places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept what was in the tooltip previously.

@MontrealSergiy
Copy link
Contributor

MontrealSergiy commented Dec 4, 2024

It works. Yet a) since now the behavior of (more) is different from other pages: for instance the tool list from menu preservers old behaviour, I would rename one of them, say into (help), (about), (info), +, ... or use a unicode symbol or emoji 🛈, ℹ️ , 💡, 🤷, 🔧 or similar. Underlining the tool name so user is enticed to point the mouse is good too. b) I think @bryancaron suggested that we might wish to add scroll bar if tool info is over one page. I know that so far tool descriptions are concise, so does not feel critical. Maybe check with him.

<td><%= overlay_description((name + "\n" + description).strip) %></td>
<td>
<%= name %>
<%= closable_overlay_content_link(name, "(iz)", description) %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What "(iz)" is? Is it some abbreviation? Would "(i)" be better?

@MontrealSergiy
Copy link
Contributor

Thanks for renaming 'more', though I am not sure what "(iz)" stands for

@MontrealSergiy MontrealSergiy self-requested a review December 17, 2024 16:40
Copy link
Contributor

@MontrealSergiy MontrealSergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants