-
Notifications
You must be signed in to change notification settings - Fork 183
Add REDCap automatic session creation #9840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add REDCap automatic session creation #9840
Conversation
64a5f5b
to
49d3b90
Compare
The CI errors are on main and not from this PR. Fixed the remaining TODO and successfully tested on C-BIG dev. Ready for review. I only added the last commit and rebased on main since last review. PR history is just messy because of the rebases, the commit history is still clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, but LGTM if that was already tested on C-BIG dev.
Most of the name changes are coming from the previous PR.
modules/redcap/php/client/models/records/redcaprecord.class.inc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ridz1208 let me know, but if already tested on C-BIG, LGTM.
I am interested to port it to IBIS too for more tests, if possible in few weeks.
@regisoc functional on CBIG! |
Blocked by the following:
EDIT: Last two points are done, see last two commits. |
40732ee
to
de863a1
Compare
de863a1
to
b23d00d
Compare
b23d00d
to
86345aa
Compare
First two commits are #9839.
Successfully tested in C-BIG dev (in a backported version).