Add key to the Comment field of feedback_mri_comments to improve querying time #9800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
Language: SQL
|
@cmadjar This is failing when sourcing the schema because of the SQL error: "ERROR 1170 (42000) at line 2265: BLOB/TEXT column 'Comment' used in key specification without a key length" I'm not really sure why that's happening with the API tests and not the other ones, but it seems to be a real error and not a sporadic failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Adding this index improved querying from 2 minutes to 3 seconds on the feedback_mri_comments on HBCD (which contains 12063735).
Testing instructions (if applicable)