PHP Docker update from 8.0 to 8.3 in CI #9530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kongtiaowang
changed the title
kongtiaowang
added
the
State: Needs work
|
@kongtiaowang does this still need work or should it be assigned? |
kongtiaowang
added
Area: CI
kongtiaowang
force-pushed
the
2025-01-09-a
branch
from
204c205 to
f5c806f
Compare
kongtiaowang
force-pushed
the
2025-01-09-a
branch
from
634a2a7 to
24390d6
Compare
kongtiaowang
force-pushed
the
2025-01-09-a
branch
2 times, most recently
from
5edb4d2 to
1c02bdd
Compare
driusan
requested changes
Feb 12, 2025
driusan
requested changes
Feb 12, 2025
| @@ -31,7 +31,10 @@ | |||
| "suppress_issue_types" => [ | |||
| "PhanUnusedPublicNoOverrideMethodParameter", | |||
| // Until phan/phan#4746 is fixed | |||
| "PhanTypeMismatchArgumentInternal" | |||
| "PhanTypeMismatchArgumentInternal", | |||
| "PhanUndeclaredMethod", | |||
There was a problem hiding this comment.
Why are these being added? If we've already fixed this class of errors they shouldn't be re-added.
| "phan/phan": "^5.0", | ||
| "phpstan/phpstan": "^1.4", | ||
| "slevomat/coding-standard": "^6.4", |
There was a problem hiding this comment.
If these changes are causing large amounts of changes, I think they should be done 1 at a time in different pull requests to make it easier to review and test them individually.
|
@kongtiaowang todo: close this PR and create a new one with less files changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First Step: 8.3
PHP Docker update from 8.0 to 8.3 in CI
Test: pass CI
todo: add 8.4