-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data_release] Introduce Manage File, Revamp Manage Permissions, Hide, Delete #9445
base: main
Are you sure you want to change the base?
[data_release] Introduce Manage File, Revamp Manage Permissions, Hide, Delete #9445
Conversation
} | ||
|
||
$DB = $this->loris->getDatabaseConnection(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing " $DB->delete('data_release_permissions',[ 'data_release_id' => $data_release_id,]);" here. Otherwise it will cause 500 error when delete a file.
[Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (wangshen_dev_hbcd
.data_release_permissions
, CONSTRAINT FK_data_release_id
FOREIGN KEY (data_release_id
) REFERENCES data_release
(id
))#0 /var/www/Loris/php/libraries/Database.class.inc(624): PDO->exec()\n#1 /var/www/Loris/modules/data_release/php/files.class.inc(402): Database->delete()\n#2 /var/www/Loris/modules/data_release/php/files.class.inc(68): ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…_Hide_Delete_Manage_Modify
I hided a file using admin account, Then I created a new account with all data_release permissions. the data_release page can't load. |
@kongtiaowang Fixed! Thank you so much for catching that. Oversight on my part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…_Hide_Delete_Manage_Modify
Brief summary of changes
Testing instructions (if applicable)
CCNA OVERRIDE PR
CCNA OVERRIDE PR