[Core] Add ProjectID Singleton #9343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a ProjectID singleton and uses it throughout LORIS. The reasoning is similar to CenterID::singleton, the values are often repeated and need to be converted to a class for many function calls, in particular when doing permission checking in batch (ie when querying data in the dataquery module.) By using a singleton, the pressure on the garbage collector is lowered as it's not constantly creating/collecting the same values.
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
This adds a ProjectID singleton and uses it throughout LORIS. The reasoning is similar to CenterID::singleton, the values are often repeated and need to be converted to a class for many function calls, in particular when doing permission checking in batch (ie when querying data in the dataquery module.) By using a singleton, the pressure on the garbage collector is lowered as it's not constantly creating/collecting the same values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a ProjectID singleton and uses it throughout LORIS. The reasoning is similar to CenterID::singleton, the values are often repeated and need to be converted to a class for many function calls, in particular when doing permission checking in batch (ie when querying data in the dataquery module.) By using a singleton, the pressure on the garbage collector is lowered as it's not constantly creating/collecting the same values.