Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DQT] Array and link support in cell data #8344

Merged
merged 3 commits into from
Jul 11, 2023
Merged

[DQT] Array and link support in cell data #8344

merged 3 commits into from
Jul 11, 2023

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Jan 30, 2023 •
edited
Loading

Display array values saved in the DQT in a grid layout.
It was displayed in a comma separated string before which can be difficult to read.

Screen Shot 2023-01-30 at 1 53 24 PM

@laemtl laemtl force-pushed the dqt-array-and-link-support branch 3 times, most recently from 41be3f5 to 5d1791a Compare February 3, 2023 19:15
@laemtl laemtl force-pushed the dqt-array-and-link-support branch from 5d1791a to d5cbec4 Compare February 14, 2023 18:41
@laemtl laemtl added this to the 25.0.0 milestone Feb 28, 2023
@laemtl laemtl closed this Mar 16, 2023
@laemtl laemtl reopened this Mar 17, 2023
@laemtl laemtl closed this Mar 28, 2023
@laemtl laemtl reopened this Mar 28, 2023
@laemtl laemtl force-pushed the dqt-array-and-link-support branch from d5cbec4 to a90f999 Compare March 28, 2023 16:55
@laemtl laemtl added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Apr 4, 2023
@laemtl laemtl changed the base branch from main to 25.0-release April 4, 2023 15:13
@laemtl laemtl removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Apr 4, 2023
xlecours
xlecours requested changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@xlecours xlecours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected, but only works when display is cross sectional.
The getRowData function block is split in two depending on display type.

@laemtl laemtl assigned laemtl and unassigned xlecours Apr 18, 2023
@laemtl laemtl added the State: Needs work PR awaiting additional work by the author to proceed label Apr 19, 2023
@laemtl laemtl force-pushed the dqt-array-and-link-support branch from a90f999 to 54db056 Compare May 30, 2023 14:57
@laemtl laemtl removed the State: Needs work PR awaiting additional work by the author to proceed label May 31, 2023
@laemtl laemtl requested a review from xlecours May 31, 2023 15:13
@laemtl laemtl force-pushed the dqt-array-and-link-support branch from b160349 to 34982aa Compare May 31, 2023 15:20
@laemtl laemtl force-pushed the dqt-array-and-link-support branch from 34982aa to f346e7a Compare May 31, 2023 15:54
@driusan driusan merged commit cff79e5 into aces:25.0-release Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlecours xlecours Awaiting requested review from xlecours

Assignees

@laemtl laemtl

Labels
None yet
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@laemtl @xlecours @driusan