[Tools] Fix to prevent fatal in fix_candidate_age.php #7546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
reviewed
Aug 23, 2021
Comment on lines
22
to
31
| $instruments = \NDB_BVL_Instrument::getInstrumentsList( | ||
| new \LORIS\LorisInstance( | ||
| $DB, | ||
| $config, | ||
| [ | ||
| __DIR__ . "/../../project/modules", | ||
| __DIR__ . "/../../modules/", | ||
| ], | ||
| ) | ||
| ); |
There was a problem hiding this comment.
@laemtl could you define the lorisinstance in the generic_includes.php so all tools can use it ?
laemtl
force-pushed
the
2021-08-23-tools-fix-candidate-age-fix
branch
from
d0f6c97 to
ae4baa0
Compare
ridz1208
approved these changes
Aug 23, 2021
laemtl
added
"Help! I don't understand Travis!"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7545