Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Publication] Display all filterable columns in list #7277

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Jan 7, 2021

The publication module allows filtering hidden columns, which is confusing.
This PR makes all the filterable columns visible.

@laemtl laemtl added the Area: UI PR or issue related to the user interface label Jan 7, 2021
@driusan
Copy link
Collaborator

driusan commented Jan 8, 2021

looks simple enough.. @kongtiaowang could you test/review this?

@laemtl laemtl requested a review from kongtiaowang January 18, 2021 20:39
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and pass test.

@kongtiaowang kongtiaowang added the Passed manual tests PR has been successfully tested by at least one peer label Jan 20, 2021
@driusan driusan merged commit 62d654c into aces:main Jan 25, 2021
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
The publication module allows filtering hidden columns, which is confusing.
This makes all the filterable columns visible.

    Resolves aces#7209
@ridz1208 ridz1208 added this to the 24.0.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI PR or issue related to the user interface Passed manual tests PR has been successfully tested by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[23.0][Publications] - Keywords and Collaborators not filtering
4 participants