[Tools] Generate Candidate External IDs #7095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
force-pushed
the
2020-10-14-generate-externalID
branch
from
608bf87 to
0723e14
Compare
laemtl
force-pushed
the
2020-10-14-generate-externalID
branch
from
0723e14 to
0661eb2
Compare
christinerogers
added
the
Event: Hacktoberfest 2020
|
Is there a reason this script is needed? |
|
This tool was created for another project to populate missing candidate External IDs. Submitting in case it can be useful to add such tool here too. |
ridz1208
requested changes
Nov 21, 2020
| exit(1); | ||
| } | ||
|
|
||
| // Get all Candidate with a NULL externalID |
| $i = 0; | ||
| // Update all candidates with an external ID | ||
| foreach ($cands as $cand) { | ||
| if (!$reset && $cand['ExternalID'] != null) { |
There was a problem hiding this comment.
you are using a loose operator here != instead of !== which means that this statement will return true for $cand['ExternalID'] = false, $cand['ExternalID'] = 0, $cand['ExternalID'] = "" or $cand['ExternalID'] = NULL. if this is intentional, I usually recommend using empty() to be more clear or making sure to add a specific comment justifying the !=. If this is accidental, please use is_null instead
There was a problem hiding this comment.
Thanks @ridz1208 , it's a typo.
|
Thanks @ridz1208, comments addressed. |
ridz1208
approved these changes
Nov 23, 2020
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
New tool to fill external IDs for all candidates where a NULL value is found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tool to fill external IDs for all candidates where a NULL value is found.