Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved consistency of RB data for table mri_upload. #7086

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

nicolasbrossard
Copy link
Contributor

@nicolasbrossard nicolasbrossard commented Oct 7, 2020

Brief summary of changes

Given that:

  1. There is currently only one user in raisin bread: admin.
  2. The MRI incoming directory is set to /data/incoming.
  3. When an MRI archive is successfully uploaded, it goes to <MRIIncomingDir>/<user> (where user is the ID of the user who uploaded the file).

I think it makes more sense to have all records in table mri_upload have an UploadLocation with a root directory set to /data/incoming/admin. This PR does just that.

Testing instructions (if applicable)

Make sure that the RB data in table mri_upload loads correctly and that all records in table mri_upload have an UploadLocation with a root directory set to /data/incoming/admin.

Copy link
Collaborator

@cmadjar cmadjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but the SQL changes make sense.

@driusan driusan merged commit bbf17ea into aces:main Oct 13, 2020
spell00 pushed a commit to spell00/Loris that referenced this pull request Nov 4, 2020
@ridz1208 ridz1208 added this to the 24.0.0 milestone Nov 27, 2020
AlexandraLivadas pushed a commit to AlexandraLivadas/Loris that referenced this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants