[Instrument] Make instrument data non-static #6868
Conversation
driusan
added
Blocking
|
Should we update this reference too? https://github.com/aces/Loris/blob/main/raisinbread/instruments/NDB_BVL_Instrument_aosi.class.inc#L549 |
|
Good catch, I missed that one.. updated it. |
laemtl
added
the
Passed manual tests
NDB_BVL_Instrument has an.. unusual.. way of dealing with instrument data. Rather than having a class method for getting the data, there's a static method which takes an instrument as a parameter. The result is that data can not be cached in the object and needs to be continuously re-loaded from the database every time if it's needed multiple times in the same request. (For instance, calling getFieldValue for different fields in a script.) This adds a normal getter and caches the results in the object, deprecating the old static loadInstanceData and its inexplicable behaviour.
|
One last thing! Phan is throwing some errors: test/unittests/NDB_BVL_Instrument_Test.php:1140 PhanDeprecatedFunction Call to deprecated function \NDB_BVL_Instrument::loadInstanceData() defined at php/libraries/NDB_BVL_Instrument.class.inc:2170 (Deprecated because: use $instrumentInstance->getInstanceData() instead) |
driusan
force-pushed
the
getInstanceData
branch
from
bbb0066 to
ae03bb3
Compare
| * @return void | ||
| */ | ||
| function testLoadInstanceData() | ||
| function getLoadInstanceData() |
|
One test is failing.
/app/test/unittests/NDB_BVL_Instrument_Test.php:1602 |
|
Impressive, the tests are running really fast with Github actions. |
|
I think the individual test suites take about the same amount of time, but they start a lot faster. |
NDB_BVL_Instrument has an.. unusual.. way of dealing with instrument data. Rather than having a class method for getting the data, there's a static method which takes an instrument as a parameter. The result is that data can not be cached in the object and needs to be continuously re-loaded from the database every time if it's needed multiple times in the same request. (For instance, calling getFieldValue for different fields in a script.) This adds a normal getter and caches the results in the object, deprecating the old static loadInstanceData.
NDB_BVL_Instrument has an.. unusual.. way of dealing with instrument
data. Rather than having a class method for getting the data, there's
a static method which takes an instrument as a parameter. The result
is that data can not be cached in the object and needs to be continuously
re-loaded from the database every time if it's needed multiple times in
the same request. (For instance, calling getFieldValue for different fields
in a script.)
This adds a normal getter and caches the results in the object, deprecating
the old static loadInstanceData and its inexplicable behaviour.