-
Notifications
You must be signed in to change notification settings - Fork 186
Closed
Labels
24.0.0-bugsIssues or bug fix PRs that were raised during the testing of release 24.0.0Issues or bug fix PRs that were raised during the testing of release 24.0.0Category: BugPR or issue that aims to report or fix a bugPR or issue that aims to report or fix a bugCleanupPR or issue introducing/requiring at least one clean-up operationPR or issue introducing/requiring at least one clean-up operationProposalPR or issue suggesting an improvement that can be accepted, rejected or alteredPR or issue suggesting an improvement that can be accepted, rejected or altered
Description
Describe the bug
Our webpack file contains the following line
util: path.resolve(__dirname, './htdocs/js/util'),
I would like to make a PR to 24.1 to remove it for the following reasons
- It seems to be unused in the code
- The
util
nomenclature is too generic and it seems to cause collision with other existing utilities. one example of that is when you try to incorporate the Open Science Identity bundle and run npm run compile, the error below shows up due to the existance of the shortcututil
pointing to our own util class.Child ERROR in ./project/modules/new_profile/node_modules/readable-stream/lib/_stream_readable.js Module not found: Error: Can't resolve 'util' in '/var/www/loris/project/modules/new_profile/node_modules/readable-stream/lib'
Metadata
Metadata
Assignees
Labels
24.0.0-bugsIssues or bug fix PRs that were raised during the testing of release 24.0.0Issues or bug fix PRs that were raised during the testing of release 24.0.0Category: BugPR or issue that aims to report or fix a bugPR or issue that aims to report or fix a bugCleanupPR or issue introducing/requiring at least one clean-up operationPR or issue introducing/requiring at least one clean-up operationProposalPR or issue suggesting an improvement that can be accepted, rejected or alteredPR or issue suggesting an improvement that can be accepted, rejected or altered