Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examiner] Special characters in examiner names should not be allowed #7965

Open
ridz1208 opened this issue Jan 26, 2022 · 1 comment
Open
Assignees
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Category: Bug PR or issue that aims to report or fix a bug Module: examiner PR or issue related to examiner module
Milestone

Comments

@ridz1208
Copy link
Collaborator

ridz1208 commented Jan 26, 2022

Describe the bug
Special characters should not be allowed in examiner names. Special characters get escaped when saved in the database and cause an error when associating examiners with sites.

NOTE: It is "normal" that an error is thrown because when the examiner name contains special characters, it is escaped on the way to the DB and thus can not be searched for to associate with sites in the examiner_psc_rel table. (long story short, the error is normal, there is just no reason for special characters here)

To Reproduce
Steps to reproduce the behavior (attach screenshots if applicable):

  1. Go to the examiner module
  2. add an examiner with name test" &string <with> characters
  3. notice Error.
@ridz1208 ridz1208 added Category: Bug PR or issue that aims to report or fix a bug 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Jan 26, 2022
@ridz1208 ridz1208 mentioned this issue Jan 26, 2022
14 tasks
@ridz1208 ridz1208 changed the title [examiner] Error swal contains entire workspace [examiner] Special characters in examiner names should not be allowed Jan 27, 2022
@ridz1208
Copy link
Collaborator Author

@KLaFleur can you add a validator to make sure the characters "&<> are not accepted on submission

@driusan driusan added the Module: examiner PR or issue related to examiner module label Jan 21, 2025
@driusan driusan added this to the 27.0.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Category: Bug PR or issue that aims to report or fix a bug Module: examiner PR or issue related to examiner module
Projects
Status: No status
Development

No branches or pull requests

3 participants