Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes font family inconsistency on the Methods page #85

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fixes font family inconsistency on the Methods page #85

merged 1 commit into from
Aug 2, 2024

Conversation

jikaczmarski
Copy link
Collaborator

@jikaczmarski jikaczmarski commented Aug 2, 2024

Importing of the bootstrap CSS style sheet in an OJS block caused an overriding of the default sans serif font family. Removing the CSS call does not appear to break any functionality.

@jikaczmarski jikaczmarski added the bug Something isn't working label Aug 2, 2024
@jikaczmarski jikaczmarski requested a review from ianalexmac August 2, 2024 22:27
Copy link
Collaborator

@ianalexmac ianalexmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job hunting the bug!

@ianalexmac ianalexmac merged commit e1efc01 into acep-uaf:main Aug 2, 2024
@ianalexmac
Copy link
Collaborator

For what it's worth, the Leaflet stylesheet remains and does not appear to be causing the problem. This PR removed the Bootstrap CSS stylesheet.

@jikaczmarski
Copy link
Collaborator Author

For what it's worth, the Leaflet stylesheet remains and does not appear to be causing the problem. This PR removed the Bootstrap CSS stylesheet.

That's good to know! I'll go ahead and make semantics changes.

@jikaczmarski jikaczmarski deleted the merge-formatting branch August 3, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants