add conditional cross-references #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jikaczmarski
previously requested changes
Aug 1, 2024
There was a problem hiding this comment.
This is a tremendous amount of work and I commend you all!
I have one request before we proceed with a merge - I would like to enforce the same font between the web book's text and the figure text. As it stands, figure text is serif and all else is sans serif:
This may require being explicit about the font that Quarto uses if we can't nail it down.
jikaczmarski
dismissed
their stale review
Consensus that the fonts shouldn't block progress at the moment.
jikaczmarski
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #79 and #80