Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical - Only stitch wounds on not bleeding body parts #7044

Merged
merged 6 commits into from
Sep 28, 2019

Conversation

mharis001
Copy link
Member

@mharis001 mharis001 commented Jun 8, 2019

When merged this pull request will:

  • Change stitching to only be possible for bandaged wounds on not bleeding body parts
  • Fix issue where another stitched wound would be added instead of increasing the amount

@alganthe alganthe mentioned this pull request Jun 8, 2019
28 tasks
@TheMagnetar
Copy link
Member

I think it should be a setting and default turned off.

@alganthe
Copy link
Contributor

alganthe commented Jun 8, 2019

Same, should be a setting like in current.

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jun 9, 2019
@PabstMirror PabstMirror added this to the Medical Rewrite milestone Jun 9, 2019
@commy2
Copy link
Contributor

commy2 commented Jun 9, 2019

I think it should be a setting... and default turned on :P

@dedmen
Copy link
Contributor

dedmen commented Jun 11, 2019

I think it should be a setting... and default turned on :P

But muh realism, I can stitch that bleeding guy if I want to!

@kymckay
Copy link
Member

kymckay commented Jun 12, 2019

Now that you mention realism, why should stable condition be a requirement? (I may have missed a meeting where this setting was discussed).

Shouldn't it just be GET_WOUND_BLEEDING(_unit) == 0? Otherwise you can't stitch someone who's unconscious.

@dedmen
Copy link
Contributor

dedmen commented Jun 12, 2019

why should stable condition be a requirement

Good point too. I thought of "stable" as not bleeding, but it's actually alot more.

https://github.com/acemod/ACE3/blob/847d2d41792b9d0f9ab27bb7b6ebf7eedaaa3907/addons/medical_status/functions/fnc_hasStableVitals.sqf

I can stitch someone with severe bloodloss or in cardiac arrest or with low heart rate or with low blood pressure.
It might not make sense, but nothing really prevents me from doing it.

@jonpas
Copy link
Member

jonpas commented Jun 12, 2019

Agreed, only bleeding should be stopped before stitching. The rest is up to medic's knowledge.

@kymckay
Copy link
Member

kymckay commented Jun 12, 2019

I'd maybe even go as far as saying a setting isn't needed if we just say bleeding should always be stopped before stitching

@dedmen
Copy link
Contributor

dedmen commented Jun 13, 2019

That opens a problem tho, you cannot stitch specific body parts can you? If you have problems with constant wound reopening (Left arm is now closed, but right arm already reopened) you can never get him dry.
Currently in old medical we just stitch in-between while someone else is bandaging, to close the already bandaged bodyparts and prevent reopening.

Maybe we can just allow stitching if there is atleast one bodypart that can be stitched (has wounds, but not bleeding) and then let it only stitch the parts that are able to (Needs to also adjust the timer).

@mharis001
Copy link
Member Author

Maybe we can just allow stitching if there is atleast one bodypart that can be stitched (has wounds, but not bleeding) and then let it only stitch the parts that are able to (Needs to also adjust the timer).

This could work.

We could also change stitching to be body part specific if we go this route. Thoughts?

@Drofseh
Copy link
Contributor

Drofseh commented Jun 17, 2019

I would like that

@dedmen
Copy link
Contributor

dedmen commented Jun 18, 2019

We could also change stitching to be body part specific if we go this route. Thoughts?

If we adjust the timer accordingly I think that's good.
But I think people will complain as you usually get multiple wounds.

@alganthe
Copy link
Contributor

The stitching kit removes wounds as the bar progresses, there's no need to make it work on a per limb basis.

PabstMirror and others added 3 commits August 28, 2019 11:09
@mharis001 mharis001 changed the title Medical - Require stable condition for stitching Medical - Only stitch wounds on not bleeding body parts Sep 28, 2019
@kymckay
Copy link
Member

kymckay commented Sep 28, 2019

All looks good to me, but another set of eyes should look it over before approving

Co-Authored-By: SilentSpike <silentspike100+Github@gmail.com>
@kymckay kymckay merged commit ec9e6c0 into master Sep 28, 2019
@kymckay kymckay deleted the surgical-kit-stable branch September 28, 2019 20:48
@PabstMirror PabstMirror modified the milestones: Medical Rewrite, 3.13.0 Dec 30, 2019
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.13.0-temp2 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants