Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(macro): use DCHECK* to replace dbg_dassert and self defined ASSERT_* #41

Closed
wants to merge 4 commits into from
Closed

refactor(macro): use DCHECK* to replace dbg_dassert and self defined ASSERT_* #41

wants to merge 4 commits into from

Conversation

acelyc111
Copy link
Owner

@acelyc111 acelyc111 commented Nov 6, 2022 •
edited
Loading

apache#1204

  • dbg_dassert -> DCHECK*
  • add debug type of DCHECK* for CHECK*
  • remove self defined ASSERT_* from .cpp files

@github-actions github-actions bot added the cpp label Nov 6, 2022
@acelyc111 acelyc111 changed the title Check all3 refactor(macro): use DCHECK* instead of dbg_dassert and self defined ASSERT_* Nov 6, 2022
@acelyc111 acelyc111 changed the title refactor(macro): use DCHECK* instead of dbg_dassert and self defined ASSERT_* refactor(macro): use DCHECK* to replace dbg_dassert and self defined ASSERT_* Nov 6, 2022
@acelyc111 acelyc111 closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cpp java-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acelyc111 @Praying @empiredan