Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fields are hardcoded in forms.py #298

Closed
b1rger opened this issue Sep 25, 2023 · 0 comments · Fixed by #303 or #289
Closed

Fields are hardcoded in forms.py #298

b1rger opened this issue Sep 25, 2023 · 0 comments · Fixed by #303 or #289

Comments

@b1rger
Copy link
Contributor

b1rger commented Sep 25, 2023

There are field names hardcoded in forms.py:

apis-core-rdf/apis_core/apis_entities/forms.py

Line 182 in 8aa5394

self.fields["collection"].required = False

This breaks ontologies if they don't use those fields in their entities
b1rger added a commit that referenced this issue Sep 25, 2023
@b1rger
fix(apis_entities): only set field attributes for existing fields
dd19103 
There is some legacy code that expects specific model fields (the ones
that were part of TempEntityClass). This commit checks if those even
exist, before setting their attributes.

Closes: #298
@b1rger b1rger mentioned this issue Sep 25, 2023
Merged
b1rger added a commit that referenced this issue Sep 27, 2023
@b1rger
fix(apis_entities): only set field attributes for existing fields
100de8c 
There is some legacy code that expects specific model fields (the ones
that were part of TempEntityClass). This commit checks if those even
exist, before setting their attributes.

Closes: #298
@github-actions github-actions bot mentioned this issue Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@b1rger