Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize auto-detected paths #600

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

achrefbensaad
Copy link
Contributor

optimize auto-detected paths

Copy link
Contributor

@seswarrajan seswarrajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ankurk99
Copy link
Contributor

tmp files creates by applications under /tmp have random names and are not consistant between pod restarts, so we need to allow /tmp/**.
Adding tmp there is the simplest way to guarenty that behaviour

But we have also seen this behaviour with the "var" folder too (both /var/ and /var) enteries exist, right?

@achrefbensaad
Copy link
Contributor Author

But we have also seen this behaviour with the "var" folder too (both /var/ and /var) enteries exist, right?

Thats in the summary not in the wpfs

Copy link
Contributor

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to take a look at the go-lint warning. Otherwise LGTM 👍

@nyrahul nyrahul merged commit f865f75 into accuknox:dev Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants