Autoloading of projection classes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code style changes are cool - I try to stick to PSR styling personally. Much of this code was a direct port from JavaScript, and some styling got carried across. I was concentrating mainly on functionality, and not gone back to fix styling yet. |
judgej
added a commit
that referenced
this pull request
Apr 27, 2015
Autoloading of projection classes
|
Thanks. |
|
Wow! Thanks for the very quick response ;) |
|
Haven't tested your changes, but it all looks good, so I just went for it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I got WGS84 -> EPSG:31467 (my use case) working by fixing the autoloading of projection classes (dc47e5d, 4a04a90).
If you don't agree on the code style changes (e544667) I would gladly make a pull request without them.