Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorUrl() should default to returnUrl() #4

Closed
judgej opened this issue Aug 22, 2018 · 1 comment
Closed

errorUrl() should default to returnUrl() #4

judgej opened this issue Aug 22, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@judgej
Copy link
Member

judgej commented Aug 22, 2018

Omnipay does not distinguish between a success URL (authorised) and an error URL (declined), but Datatrans does, and requires both URLs to be supplied. The URLs can be set in the account and left unset at runtime, or set at runtime.

If set at runtime, when an application sets just the returnUrl() then it expects both success and error results to go to the same place. In this case errorUrl() needs to default to the returnUrl().

An application should still be able to supply a separate errorUrl() if it needs to use it.

@judgej judgej added the bug Something isn't working label Aug 22, 2018
@judgej judgej self-assigned this Aug 22, 2018
judgej added a commit that referenced this issue Aug 22, 2018
For card tokenisation, and authorize/purchase.
@judgej judgej added the next release Fixed for next release label Dec 2, 2018
@judgej
Copy link
Member Author

judgej commented Jan 5, 2019

This would have made it into release version 3.0.5 but wasn't noted at the time.

@judgej judgej closed this as completed Jan 5, 2019
@judgej judgej removed the next release Fixed for next release label Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant