Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: removed support for dmsp_ssj_boundaries #139

Merged
merged 14 commits into from
Jun 20, 2024
Merged

DEP: removed support for dmsp_ssj_boundaries #139

merged 14 commits into from
Jun 20, 2024

Conversation

aburrell
Copy link
Owner

@aburrell aburrell commented Jun 18, 2024

Description

Removed support for old package `dmsp_ssj_boundaries. Fixes #129 and #135.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests.

import ocbpy

# Fetch the zenodo archive for all dates and satellites.
ocbpy.boundaries.dmsp_ssj_files.fetch_ssj_boundary_files()

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.9
  • Any details about your local setup that are relevant: develop branch of pysat

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My commits are formatted appropriately (following the SciPy/NumPy style)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to Changelog.rst, summarising the changes
  • Add yourself to AUTHORS.rst and .zenodo.json

aburrell added 14 commits June 18, 2024 11:16
Removed deprecated functions that relied on `ssj_auroral_boundaries`.
Removed unit tests for deprecated functions that have been removed.
Updated the citation guidelines for the DMSP SSJ data.
Added a summary of the changes to the changelog.
Removed the deprecated dependency for DMSP SSJ data.
Removed the extras testing support file.
Updated test yamls to use pyproject.toml instead of the requirements.extras file.
Removed the tab from the yaml file.
Removed unneeded environment variable definition for CDF files.
Updated the yaml text evaluation.
Fix string evaluation and add the missing pysat setup section.
Update the zenodo-get installation name.
Updated the failure message for the DMSP SSJ function.
Updated `test_fetch_format_ssj_boundary_files_no_rm_temp` to check for a zip archive instead of CDF files.
@coveralls
Copy link

Coverage Status

coverage: 99.775% (+7.6%) from 92.213%
when pulling 5c17a34 on ssj_dep
into 6fe61d2 on develop.

@aburrell aburrell added this to the v0.5.0 milestone Jun 20, 2024
@aburrell aburrell merged commit 48d4654 into develop Jun 20, 2024
79 checks passed
@aburrell aburrell deleted the ssj_dep branch June 20, 2024 15:53
@aburrell aburrell mentioned this pull request Jun 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: add zenodo tests for windows and mac MAINT: remove reqirements.extra
2 participants