Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency conventional-changelog to v4 #176

Conversation

mrgrain
Copy link

@mrgrain mrgrain commented Aug 24, 2024

Updates conventional-changelog to v4.0.0 to get rid of a lot of outdated dependencies and their warnings, mostly q from all the presets?

Why v4.0.0?
By process of elimination:

  • v6 uses ESM ❌
  • v5 uses git-raw-commits v4, which uses dynamic imports, which causes jest to fail with default config (see below) ❌
  • v4 passes all tests locally ✅

The v5 issue
When running tests, we get the following failure, because git-raw-commits v4 uses a dynamic import:

TypeError: A dynamic import callback was invoked without --experimental-vm-modules

This failure appears to be an issue with Jest only, and could be fixed by running tests with an experimental node flag.
See: https://jestjs.io/docs/ecmascript-modules

@mrgrain
Copy link
Author

mrgrain commented Aug 24, 2024

@TimothyJones Would appreciate a review. The transitive dependency on q causes a lot of warnings like this (one per preset package):

warning commit-and-tag-version > conventional-changelog > conventional-changelog-conventionalcommits > q@1.5.1: You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (7ebdacd) to head (8968414).
Report is 16 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
- Coverage   94.11%   92.87%   -1.25%     
==========================================
  Files          26       28       +2     
  Lines         493      519      +26     
==========================================
+ Hits          464      482      +18     
- Misses         29       37       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimothyJones TimothyJones merged commit 8d15fc7 into absolute-version:master Aug 25, 2024
8 checks passed
@TimothyJones
Copy link
Member

Thanks so much for this!

Also, thanks for your work maintaining jsii - I thought your name was familiar, turns out we came across each other on this issue a while back!

I'll get this released today

@TimothyJones
Copy link
Member

Released in 12.4.2.

@mrgrain
Copy link
Author

mrgrain commented Aug 25, 2024

Thanks so much for this!

Also, thanks for your work maintaining jsii - I thought your name was familiar, turns out we came across each other on this issue a while back!

I'll get this released today

Oh haha this is funny. I also thought I recognized your avatar, but couldn't quite place it.

Thanks for the review and release! If you're curious, we are finally moving projen to use this fork instead of standard-version.

@mrgrain mrgrain deleted the mrgrain/conventional-changelog-v4 branch August 25, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants