Fix broken guide links #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Hey. This change makes it so that links are now broken when reading the external website version of the guides as they have the .html extension is there a way these paths could be mapped so the links can work on both github and the hexdocs page? or maybe a way of generating them dinamically? |
|
Excellent question and point. Yeah I’m going explore solutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I noticed that in the tutorial guide, the links to each next step in the tutorial are broken, as they refer to
<link-to-next-step>.html, rather than using a.mdextension. This PR addresses this problem by changing each<link-to-next-step>extension to.md.I see that PR #777 begins to address this issue, and there may be more. I will look through when I get a chance to make sure all other guide links are updated.