Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand error message for invalid resolver #749

Conversation

maartenvanvliet
Copy link
Contributor

I ran across an issue where I accidentally had a invalid resolver but was unable to quickly trace where it was defined.

This PR makes the error more verbose and adds the field name and where it was defined to the error message. I also added a test for this behaviour.

Copy link
Contributor

@benwilson512 benwilson512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've definitely run into this myself.

@bruce bruce merged commit 68b427d into absinthe-graphql:master Jun 13, 2019
@maartenvanvliet maartenvanvliet deleted the issues/expand_invalid_resolver_error branch June 13, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants