Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using custom schema directives in an Apollo federated schema. I noticed that multi-word directives were showing up as snake_case in the schema rather than camelCase. The change to
notation.ex
took care of camelCasing directives as defined in thesdl_render_test.exs
, but the additional change insdl_render.ex
seemed to be necessary to camelCase custom schema directives defined in a federated subgraph. I'm not sure how to test that here since defining them relies on Apollo'scomposeDirective
directive:Any feedback would be appreciated cc: @benwilson512