Use Task.yield/2 instead of Task.await/2 in batching fn, so we can log error #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, what function with what parameters is failing when timeout occures Instead of calling Task.await/2 which kills process after timeout has expired, use Task.yield/2, if it timeouts, kill task and log which function failed to resolve, after which we continue to act like Task.await and kill calling process (self).
benwilson512
approved these changes
Feb 14, 2024
|
@VladoPlavsic @benwilson512 I ended up trying to reimplement this today and noticed its merged to main, but not in latest -v1.7.6. Is there any chance of this making it into a release soon? This would help us a ton with tracking down failed batch resolvers in our API! |
|
By the way, I wonder if it's good for a library to just log things like this. What if someone has different logging format or needs or even some security considerations of logging the whole |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve absinthe batch logging, add useful information on what module what function with what parameters is failing when timeout occurs
Instead of calling
Task.await/2which kills process after timeout has expired, useTask.yield/2, if it timeouts, kill task and log which function failed to resolve, after which we continue to act likeTask.await/2and kill calling process (self).