Bugfix: multiple pushes per client for subscriptions that have a context_id
#1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beligante
commented
Jun 18, 2023
| @@ -49,7 +49,7 @@ defmodule Absinthe.Execution.SubscriptionTest do | |||
| @behaviour Absinthe.Subscription.Pubsub | |||
|
|
|||
| def start_link() do | |||
| Registry.start_link(keys: :unique, name: __MODULE__) | |||
| Registry.start_link(keys: :duplicate, name: __MODULE__) | |||
There was a problem hiding this comment.
Had to change this to allow duplicated keys to make the test fail and also because the registry in the sub supervisor allows duplicated keys: https://github.com/absinthe-graphql/absinthe/blob/master/lib/absinthe/subscription/supervisor.ex#L37
tristan-secord
approved these changes
Jun 19, 2023
benwilson512
requested changes
Jun 29, 2023
| @@ -49,7 +49,7 @@ defmodule Absinthe.Execution.SubscriptionTest do | |||
| @behaviour Absinthe.Subscription.Pubsub | |||
|
|
|||
| def start_link() do | |||
| Registry.start_link(keys: :unique, name: __MODULE__) | |||
| Registry.start_link(keys: :duplicate, name: __MODULE__) | |||
benwilson512
approved these changes
Jun 30, 2023
|
Amazing, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close this issue: #1064
Originally this issue seems to be introduced by this PR -- because of this specific change. It was introduced in the version
v1.6.0On the
v1.5.5the deduplication happened usingMap.newwhen looking at the Registry. By checking the current version, using the same strategy seems to fix the problem since the documents should be identical.