Pass resolution to dataloader helper's callback #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to get resolution structure from dataloader callback function. Adds support for callback with arity 4, in that case last argument will be resolution struct.
benwilson512
approved these changes
Dec 4, 2022
antonsatin
deleted the
feature/support-resolution-in-dataloader-callback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1192
Hi folks 👋🏻
This PR adds support for getting resolution inside a callback function that's passed to
dataloaderhelper. Basically it allows to passcallback/4instead ofcallback/3todataloaderoptions, in that case last argument will be resolution struct.The
do_dataloaderfunction becomes a bit thick with its arguments list, but usingoptsor changing it completely didn't seem like a good option to me either.