Parse constant values separate from locations that permit variables #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The graphql spec (https://spec.graphql.org/draft/#sec-Appendix-Grammar-Summary.Source-Text) declares that in some location a value cannot be a variable. This is especially the case in the schema definition language, where setting the values of directive arguments to a variable is not permitted. Also in executable documents, setting the default value of a variable definition to a variable is not permitted. See graphql/graphql-spec#918 (comment) for more on this.
kdawgwilk
approved these changes
Aug 7, 2022
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graphql spec (https://spec.graphql.org/draft/#sec-Appendix-Grammar-Summary.Source-Text)
declares that in some location a value cannot be a variable.
This is especially the case in the schema definition language, where
setting the values of directive arguments to a variable is not permitted.
Also in executable documents, setting the default value of a variable definition
to a variable is not permitted.
See graphql/graphql-spec#918 (comment)
for more on this.