Conform built in types to spec #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://spec.graphql.org/draft/#sec-Schema-Introspection `Absinthe.Introspection.Kind.kind` now returns an atom. It wasn't called anywhere except from introspection but it is a breaking change.
binaryseed
reviewed
Jan 1, 2021
| @@ -8,19 +8,20 @@ defmodule Absinthe.Introspection.Kind do | |||
| __MODULE__ | |||
| |> Module.split() | |||
| |> List.last() | |||
| |> Absinthe.Introspection.Kind.upcase() | |||
| |> Absinthe.Introspection.Kind.downcase() | |||
There was a problem hiding this comment.
Given this is enumerated now, and not just a string, I wonder if this can be simplified (ie: not use all that module / string manipulation)
It seems like the goal is just to have a function kind that returns an atom... We could get rid of the macro altogether:
defmodule Absinthe.Type.Object do
@behaviour Absinthe.Introspection.Kind
def kind, do: :object
end
defmodule Absinthe.Introspection.Kind do
@type introspection_kind :: :enum | :object # ...
@callback kind() :: introspection_kind()
endThere was a problem hiding this comment.
I think I'll do this separately...
There was a problem hiding this comment.
Actually while making this change, I found some further issues with our __TypeKind!
Further corrections here: #1019
+1 to being explicit!
There was a problem hiding this comment.
Thx, good catch!
binaryseed
approved these changes
Jan 2, 2021
maartenvanvliet
deleted the
issues/conform-introspection-schema-spec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the built in types to conform to the spec, see https://spec.graphql.org/draft/#sec-Schema-Introspection
Most notably adds the
__TypeKindenum.Absinthe.Introspection.Kind.kindnow returns an atom for the__TypeKindenum resolver.