Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LICENSE missing from sdist #94

Closed
jayvdb opened this issue Feb 26, 2019 · 2 comments
Closed

LICENSE missing from sdist #94

jayvdb opened this issue Feb 26, 2019 · 2 comments
Assignees
@rickeylev

Comments

@jayvdb
Copy link

jayvdb commented Feb 26, 2019

Please include the LICENSE into the sdist uploaded to PyPI.

Also, third_party is missing from the sdist, which probably means at least the tests will not work from the sdist.
@jayvdb
Copy link
Author

jayvdb commented Feb 26, 2019

Typically this is done by creating a MANIFEST.in, with rules for which files to include and which to exclude.

However I believe in the next release it can also be done by configuring setuptools a little. See pypa/setuptools#1636

@rickeylev
Copy link
Contributor

Just to provide an update: this is fixed, but hasn't been merged back into github. I plan to push it this week

rickeylev added a commit to rickeylev/abseil-py that referenced this issue Mar 12, 2019
@rickeylev @copybara-github
Bump absl-py to version 0.7.1
669077d 
Added:

*   (flags) `flags.mark_bool_flags_as_mutual_exclusive`: convenience function to
    check that only one, or at most one, flag among a set of boolean flags are
    True.

Changed:

*   (bazel) Bazel 0.23+ or 0.22+ is now required for building/testing.
    Specifically, a Bazel version that supports
    `@bazel_tools//tools/python:python_version` for selecting the Python
    version.

Fixed:

*   abseil#94: LICENSE files are now included in sdist.
*   abseil#93: Change log added.

PiperOrigin-RevId: 238053201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickeylev rickeylev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jayvdb @rickeylev