-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: C++ versions less than C++14 are not supported #1431
Comments
This is working as intended. |
stanhu
added a commit
to stanhu/re2
that referenced
this issue
Jul 3, 2023
Whether intentional or not, https://code-review.googlesource.com/c/re2/+/61250 made re2 depend directly on abseil. The latest version of abseil now requires C++14 (abseil/abseil-cpp#1127). However, it seems that supplying `-std=c++14` isn't enough (abseil/abseil-cpp#1431). `-std=c++17` needs to be used at least. This commit fixes the compilation by trying C++20 and C++17 if the initial compilation fails. This fixes build issues on macOS.
stanhu
added a commit
to stanhu/re2
that referenced
this issue
Jul 3, 2023
https://code-review.googlesource.com/c/re2/+/61250 made re2 depend directly on abseil. The latest version of abseil now requires C++14 (abseil/abseil-cpp#1127). However, it seems that supplying `-std=c++14` isn't enough (abseil/abseil-cpp#1431). `-std=c++17` needs to be used at least. This commit fixes the compilation by trying C++20 and C++17 if the initial compilation fails. This fixes build issues on macOS.
mudge
pushed a commit
to mudge/re2
that referenced
this issue
Jul 4, 2023
https://code-review.googlesource.com/c/re2/+/61250 made re2 depend directly on abseil. The latest version of abseil now requires C++14 (abseil/abseil-cpp#1127). However, it seems that supplying `-std=c++14` isn't enough (abseil/abseil-cpp#1431). `-std=c++17` needs to be used at least. This commit fixes the compilation by trying C++20 and C++17 if the initial compilation fails. This fixes build issues on macOS.
Can confirm this fixed it for me, too. $ bazelisk --version
bazel 6.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
I am getting the below issue:
Config:
Protobuf : 21.12
protoc : libprotoc 3.17.3
Bazel : 5.4.0
bazel depenedency:
http_archive(
name = "com_google_protobuf",
sha256 = "2118051b4fb3814d59d258533a4e35452934b1ddb41230261c9543384cbb4dfc",
strip_prefix = "protobuf-3.22.2",
urls = ["https://github.com/protocolbuffers/protobuf/archive/v3.22.2.tar.gz"],
)
Language: Golang
Steps to reproduce the problem
When I run
bazel build //...
, I am getting above issue.What version of Abseil are you using?
We are not explicitly using
absl
library. Protocol buffers uses this internally. Here I have raised an issue. They suggested me to raise a issue here.What operating system and version are you using?
MacOS Monterey 12.6.3
What compiler and version are you using?
I used the below workaround in
.bazelrc
What build system are you using?
Bazel and Version is 5.4.0.
Additional context
No response
The text was updated successfully, but these errors were encountered: