Mark test dependencies as dev dependencies #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was overlooked in #105 when rules_oci was marked as dev dependency. Without this change, depending on this module fails as loading the extension fails.
meteorcloudy
pushed a commit
to bazelbuild/bazel-central-registry
that referenced
this pull request
Dec 16, 2024
rules_oci is loaded by a non dev_dependencies module extension and therefore musn't be a dev_dependency itself. Proposed an upstream fix for future versions in abrisco/rules_helm#107.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was overlooked in #98 and #105 when rules_oci was marked as dev dependency.
Without this change, depending on this module fails as loading the extension fails as evaluating
test_extensions.bzlfails when loadingtest_deps.bzlwhich again tries to load from@rules_ociwhich it can't resolve as it is a dev dependency.