Replies: 11 comments 14 replies
-
No problem, I'll setup the testbed today and let you know my findings. |
Beta Was this translation helpful? Give feedback.
-
@abraunegg Did some tests. First to ensure that I can still reproduce the original issue with an older version:
Then with the current software for reference:
And finally with the PR:
And again, just to be sure:
PR seems to be fine, at least in regards to any regressions of this issue :) |
Beta Was this translation helpful? Give feedback.
-
Config used in the test environment:
After resyncing more than 140.000 items process exits abruptly (it seems related to curl signal managing that your are talking in other topics) but no corruption in mtime field database where found. My thoughts are the same, this PR works really well nailing down mtime corruption issue. On the performance side, same topic, too much throttling from Graph API call to get some real measures. |
Beta Was this translation helpful? Give feedback.
-
@IsmaelSF |
Beta Was this translation helpful? Give feedback.
-
@IsmaelSF as root
as normal user
The default curl version
At this point, if this is all operating OK, I will go about using If that is all operating correctly, potentially you might need to run a memory test against your system|platform if this is a physical system - you could have bad system memory .... |
Beta Was this translation helpful? Give feedback.
-
@IsmaelSF Now to do the reverse and have 100K files needed for upload .. which is your failure:
|
Beta Was this translation helpful? Give feedback.
-
@IsmaelSF after creating the directory structure , uploading the files without issue ... In your upload scenario, you have >300K files to upload ... so I also have tried that: Zero issue ... So at this point, I have think your issue is something local environment related. I can go and install Rocky Linux on a physical laptop that I have (thats going to take some time) .. If your system is a physical one, can you please download the 64Bit Memtest86 ISO from here and run it - https://www.memtest.org/ ... ensure that the system runs through all tests/patterns. If your system is not physical, you may need to redeploy / rebuild your system as you might some some sort of corruption somewhere. |
Beta Was this translation helpful? Give feedback.
-
@IsmaelSF |
Beta Was this translation helpful? Give feedback.
-
Quick update from mobile, I think that I get it. Gdb debugging activity
showed results yesterday and in back trace is segfaulting in OpenSSL
function. Let me recap all the information and will post when recover Pc
desktop access.
El sáb, 9 nov 2024, 21:50, abraunegg ***@***.***> escribió:
… @IsmaelSF <https://github.com/IsmaelSF>
Any further update here?
—
Reply to this email directly, view it on GitHub
<#2950 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE4VQZYMUUTEYIHIYNQNY23Z7ZYRPAVCNFSM6AAAAABRDLLT66VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCMJZHE4TANQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
@abraunegg this is the information I got from gdb:
I also discover that I was running onedrive client under CentoOS 7.9.2009 and not Rocky 8.x, sorry for the confusion it was my fault, my apologies, too many different servers. I'm going to upgrade openssl from default v1.0.2k to openssl-1.1.1w (lastest in 1.1.1 serie) to see if helps. Let you know my findings. |
Beta Was this translation helpful? Give feedback.
-
I've recompiled curl latest version (v8.11.0) with openssl 3.4.0, --resync for a complete synchronization and everything works!
No issues with abnormal termination or mtime corruption. Instead of changing default openssl version, I'm going to keep them in a separate environment /usr/local/ only for onedrive client and meanwhile spend much of the effort to migrate to Rocky 8.x entire server. Thank you for your incredible support. Don't hesitate to contact me to test any PRs or releases in my environment. Good work! |
Beta Was this translation helpful? Give feedback.
-
Hi @IsmaelSF and @phlibi,
Since you’ve both encountered the database corruption issue with mtime values, I wanted to reach out to see if either of you would be able to test PR #2944 given that I am 100% unable to reproduce this issue despite extensive attempts.
This PR aims to address some application performance issues by adding more frequent database checkpoints in a way that minimises impact on system I/O performance. The goal is to make database management more resilient while maintaining efficiency.
If either (or both) of you, or anyone else who is interested, could try out the changes in this PR, it would be incredibly helpful to either validate no 'mtime' corruption regression and/or confirm the performance boost this PR provides. Your feedback and any insights from testing would be greatly appreciated!
To test this PR, please look at the steps below:
Install dependencies
First install all the required platform dependencies to build the client on your respective platforms. Please read https://github.com/abraunegg/onedrive/blob/master/docs/install.md#building-from-source---high-level-requirements and then follow correctly for your platform.
Script to build PR
Once this is done, to clone the PR to resolve your issue, you can use a script like the following:
This script will create a local folder called onedrive-pr2943 with the PR version. You may need to augment the script to activate/deactivate the DMD|LDC compiler.
Testing the PR
To run the PR, you need to run the client from the PR build directory:
To install the PR, you will need to perform
sudo make install
to install the PR version to your system.When running the PR, your version should be:
onedrive v2.5.2-43-gc8d26e7
or greater.Testing Evidence
Current Release v2.5.2
Current 'master'
PR #2944
Thank you so much in advance for considering this request, and please let me know if you have any questions or need assistance in setting up the test.
Beta Was this translation helpful? Give feedback.
All reactions