Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specified types for encoding and subjectType #77

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

nitzel
Copy link
Contributor

@nitzel nitzel commented Jun 13, 2019

Specified types of FileData.endocing and FileProcessingOptions.subjectType to avoid mistakes and get autocomplete suggestions.

Specified types of `FileData.endocing` and `FileProcessingOptions.subjectType` to avoid mistakes and get autocomplete suggestions.
@abramenal
Copy link
Owner

Hi @nitzel
Thanks for the contribution! Looks really good!

@abramenal abramenal merged commit a653a88 into abramenal:master Jun 13, 2019
@abramenal
Copy link
Owner

@allcontributors add @nitzel for code

@allcontributors
Copy link
Contributor

@abramenal

I've put up a pull request to add @nitzel! 🎉

@nitzel
Copy link
Contributor Author

nitzel commented Jun 13, 2019

I hope I haven't missed any options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants