Remove "change" from drag-n-drop events

[michaeljaltamirano]

Checklist:

• No linting issues
• Commits are compliant with commitizen
• CI tests have passed
• Documentation updated
  • No updates required, JSDoc comment linking to MDN in source code

Summary of changes

A repository I work on is seeing files uploaded twice as mentioned in #276.

I dug into the local /dist of this library and noticed that removing 'change' from the SUBJECT_TYPE.DRAG_N_DROP values resolved my issue locally. It looks like 'change' is not included in the MDN docs for DragEvent.

It looks like the tests set up in this library are still passing, so I'm curious to see if this fixes people's issues without causing any regressions 🙂

Linked issues

Closes #276

[abramenal]

Thanks for the contribution! I think a small change is needed here, happy to release it as soon as it's ready

[abramenal]

I'm fine with this change. The only think that IMO important is order – it is weird to have dragend triggered before dragstart

[michaeljaltamirano]

@abramenal Thanks for the quick review! I pushed 8adf3d7 to restore the order in main with dragover added before drop, and dragexit between dragleave and dragend. Happy to make another commit if you have a specific preference of events and order not captured.

[abramenal]

Cool stuff, now order is good!
I was checking dragover event specs on MDN and have an impression that it is triggered on the element that is dragged into dropzone (or anywhere else), but not the dropzone itself.

https://jsfiddle.net/radonirinamaminiaina/zfnj5rv4/

Added console log there, trying to drop labeled div into any other down below:

Can you please double check that?

[michaeljaltamirano]

That sounds (and looks) correct. Should we remove dragexit as well? That was another event I added, and it does not seem strictly applicable to the usage in this PR, so if we're removing dragover I think it makes sense to remove dragexit as well 🙂

EDIT: I've gone ahead and just made the diff removing 'change' in 055e837, I will update the PR description now.

[abramenal]

@all-contributors add @michaeljaltamirano for code

[allcontributors]

@abramenal

I've put up a pull request to add @michaeljaltamirano! 🎉

[abramenal]

Great job @michaeljaltamirano! Let me release this now

[abramenal]

Released in v5.0.5

[8gentile]

Awesome work gang, thanks!