Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blob-storing): implement Bunny.net blob storage provider #22004

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

suhaib-mousa
Copy link
Contributor

This PR adds a new Bunny.net blob storage provider to the ABP Framework, enabling seamless integration with Bunny.net's storage service.

@suhaib-mousa
Copy link
Contributor Author

Hello @hikalkan and @maliming,

I wanted to highlight this pull request and see if it aligns with the next release.

@maliming maliming added this to the 9.2-preview milestone Feb 1, 2025
@maliming maliming self-requested a review February 1, 2025 05:59
@maliming
Copy link
Member

maliming commented Feb 4, 2025

Thank you for your contribution. Your code will be available on 9.2.

@suhaib-mousa
Copy link
Contributor Author

Thank you for your contribution. Your code will be available on 9.2.

Thanks for approving! Just curious, is the change in keyword order (e.g., static readonly, async override) for performance or just a coding convention?

I’d love to understand the reasoning behind this change for future contributions.

@maliming
Copy link
Member

maliming commented Feb 4, 2025

hi

It is just code inspection.

https://www.jetbrains.com/help/rider/ArrangeModifiersOrder.html

image

@suhaib-mousa
Copy link
Contributor Author

hi

It is just code inspection.

https://www.jetbrains.com/help/rider/ArrangeModifiersOrder.html

image

Ah, Rider! I’m still committed to Visual Studio 😂 but maybe it’s worth a try.

@maliming maliming merged commit e0c4318 into abpframework:dev Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants