Vs internal issue #5807 #21989
Merged
Vs internal issue #5807 #21989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliming
reviewed
Jan 24, 2025
| @@ -482,6 +487,7 @@ protected virtual async Task<IQueryable<IdentityUser>> GetFilteredQueryableAsync | |||
| .WhereIf(maxCreationTime != null, p => p.CreationTime <= maxCreationTime) | |||
| .WhereIf(minCreationTime != null, p => p.CreationTime >= minCreationTime) | |||
| .WhereIf(maxModifitionTime != null, p => p.LastModificationTime <= maxModifitionTime) | |||
| .WhereIf(minModifitionTime != null, p => p.LastModificationTime >= minModifitionTime); | |||
| .WhereIf(minModifitionTime != null, p => p.LastModificationTime >= minModifitionTime) | |||
| .WhereIf(id.HasValue, x => x.Id == id); | |||
There was a problem hiding this comment.
If id.HasValue, we can ignore other filters. also same for MongoIdentityUserRepository
if(id.HasValue)
{
return query.Where(x => x.Id == id);
}There was a problem hiding this comment.
I made the enhancment you mentioned.
maliming
reviewed
Jan 24, 2025
Comment on lines
467
to
471
| if (id.HasValue) | ||
| { | ||
| return query.Where(x => x.Id == id); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you move to after var query = await GetQueryableAsync();
It has priority over roleId.
maliming
approved these changes
Jan 24, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #21989 +/- ##
==========================================
+ Coverage 51.97% 52.00% +0.03%
==========================================
Files 3181 3183 +2
Lines 102210 102334 +124
Branches 7741 7772 +31
==========================================
+ Hits 53121 53219 +98
- Misses 47450 47466 +16
- Partials 1639 1649 +10 ☔ View full report in Codecov by Sentry. |
oykuermann
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Id field to be able to filter users by there Id's too.
Resolves vs-internal issue #5807
Checklist
How to test it?
You can test it at ABP Admin -> Identity Management-> Users pages filter section.