-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split monolithic "vulnerabilities" Django app #132
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e396503
Move models to a separate Django app
haikoschol 05dc6d6
Move importers to a separate Django app
haikoschol c6aac60
Move API to a separate Django app
haikoschol ea0bd5f
Remove vulnerabilities app
haikoschol 4047df5
Improve naming and update docs & CI
haikoschol 8b1243d
Remove dependency on importers from API tests
haikoschol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| from django.apps import AppConfig | ||
|
|
||
|
|
||
| class ApiConfig(AppConfig): | ||
| name = 'api' |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| [ | ||
| { | ||
| "model": "core.vulnerability", | ||
| "pk": 1, | ||
| "fields": { | ||
| "cve_id": "CVE-2014-8242", | ||
| "summary": "", | ||
| "cvss": null | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.vulnerability", | ||
| "pk": 2, | ||
| "fields": { | ||
| "cve_id": "CVE-2009-1382", | ||
| "summary": "", | ||
| "cvss": null | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.vulnerability", | ||
| "pk": 3, | ||
| "fields": { | ||
| "cve_id": "CVE-2009-2459", | ||
| "summary": "", | ||
| "cvss": null | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.package", | ||
| "pk": 1, | ||
| "fields": { | ||
| "type": "deb", | ||
| "namespace": "debian", | ||
| "name": "librsync", | ||
| "version": "0.9.7-10", | ||
| "qualifiers": "distro=jessie", | ||
| "subpath": null | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.package", | ||
| "pk": 2, | ||
| "fields": { | ||
| "type": "deb", | ||
| "namespace": "debian", | ||
| "name": "mimetex", | ||
| "version": "1.74-1", | ||
| "qualifiers": "distro=jessie", | ||
| "subpath": null | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.package", | ||
| "pk": 3, | ||
| "fields": { | ||
| "type": "deb", | ||
| "namespace": "debian", | ||
| "name": "mimetex", | ||
| "version": "1.50-1.1", | ||
| "qualifiers": "distro=jessie", | ||
| "subpath": null | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.package", | ||
| "pk": 4, | ||
| "fields": { | ||
| "type": "deb", | ||
| "namespace": "debian", | ||
| "name": "mimetex", | ||
| "version": "1.74-1", | ||
| "qualifiers": "distro=jessie", | ||
| "subpath": null | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.package", | ||
| "pk": 5, | ||
| "fields": { | ||
| "type": "deb", | ||
| "namespace": "debian", | ||
| "name": "mimetex", | ||
| "version": "1.50-1.1", | ||
| "qualifiers": "distro=jessie", | ||
| "subpath": null | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.impactedpackage", | ||
| "pk": 1, | ||
| "fields": { | ||
| "vulnerability": 1, | ||
| "package": 1 | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.resolvedpackage", | ||
| "pk": 1, | ||
| "fields": { | ||
| "vulnerability": 2, | ||
| "package": 2 | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.resolvedpackage", | ||
| "pk": 2, | ||
| "fields": { | ||
| "vulnerability": 2, | ||
| "package": 3 | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.resolvedpackage", | ||
| "pk": 3, | ||
| "fields": { | ||
| "vulnerability": 3, | ||
| "package": 4 | ||
| } | ||
| }, | ||
| { | ||
| "model": "core.resolvedpackage", | ||
| "pk": 4, | ||
| "fields": { | ||
| "vulnerability": 3, | ||
| "package": 5 | ||
| } | ||
| } | ||
| ] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are changing this, what about running
pytest -vvsonly and adding a proper entry in setup.cfg to guide the discovery?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about changing this since I don't like passing files as arguments here either. But I don't know how to do this without reading some docs and I figured it will be changed as part of #127 anyway.