Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nuget string representation #64

Merged
merged 1 commit into from
May 2, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Apr 27, 2022

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... with just a tiny nit as I prefer to keep one import per line.
Please apply and merge!

@@ -8,14 +8,14 @@
import pytest

from univers.version_constraint import VersionConstraint
from univers.version_range import GemVersionRange
from univers.version_range import GemVersionRange, NugetVersionRange
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from univers.version_range import GemVersionRange, NugetVersionRange
from univers.version_range import GemVersionRange
from univers.version_range import NugetVersionRange

from univers.version_range import InvalidVersionRange
from univers.version_range import PypiVersionRange
from univers.version_range import VersionRange
from univers.version_range import RANGE_CLASS_BY_SCHEMES
from univers.version_range import NpmVersionRange
from univers.version_range import OpensslVersionRange
from univers.versions import PypiVersion
from univers.versions import NugetVersion, PypiVersion
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from univers.versions import NugetVersion, PypiVersion
from univers.versions import NugetVersion
from univers.versions import PypiVersion

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 merged commit e801ec4 into aboutcode-org:main May 2, 2022
keshav-space pushed a commit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants