Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new ScanCode Package attributes to DataTables #81

Closed
jdaguil opened this issue May 17, 2017 · 5 comments
Closed

Add new ScanCode Package attributes to DataTables #81

jdaguil opened this issue May 17, 2017 · 5 comments
Assignees
@jdaguil
Labels
DataTables enhancement must have
Milestone
v2.0.0

Comments

@jdaguil
Copy link
Contributor

jdaguil commented May 17, 2017

There are new package attributes that should be added to the table view
@jdaguil jdaguil added this to the v2.0.0 milestone May 17, 2017
@jdaguil jdaguil self-assigned this May 17, 2017
@mjherzog
Copy link
Member

mjherzog commented May 17, 2017 •
edited by jdaguil
Loading

The most important new attributes for analysis are:

  • package_name
  • package_version
  • package_authors
  • package_homepage_url
  • package_download_urls
  • package_asserted_licenses

but it probably makes sense to add them all

@mjherzog
Copy link
Member

We should have a Package Info choice for Column Visibility

jdaguil added a commit that referenced this issue May 20, 2017
@jdaguil
Adding new Package attributes #81
22b2c6f 
* Updated DataTable to show new attributes
* Updated Flattened File Model with new attributes
* Added getNestedValues method which gets keys from an object that
  is nested two levels deep
* Updated tests

Signed-off-by: Jillian Daguil <jdaguil@nexb.com>
jdaguil added a commit that referenced this issue May 20, 2017
@jdaguil
Added Package author attributes #81
3dbfb86 
* Added type, email, and url
* Updated tests

Signed-off-by: Jillian Daguil <jdaguil@nexb.com>
jdaguil added a commit that referenced this issue May 21, 2017
@jdaguil
Added package asserted licenses attributes #81
984480f 
* Added additional asserted license attributes (url, text, notice)
  to Package Model
* Rearranged DataTable columns
* Removed Packaging column from DataTable view
* Updated test file

Signed-off-by: Jillian Daguil <jdaguil@nexb.com>
jdaguil added a commit that referenced this issue May 21, 2017
@jdaguil
Updated Package Download URLs #81
cdd6504 
* Updated DataTable to show multiple package download urls

Signed-off-by: Jillian Daguil <jdaguil@nexb.com>
@jdaguil
Copy link
Contributor Author

jdaguil commented May 22, 2017

@mjherzog I've added the subset of attributes you have listed, and I can merge that work into develop. I'm currently blocked by aboutcode-org/scancode-toolkit#617. I need additional information to add the other attributes correctly to our models and to the table view.

@jdaguil
Copy link
Contributor Author

jdaguil commented May 22, 2017

@mjherzog I will open a separate issue for adding the Package Info button

@pombredanne pombredanne mentioned this issue Jul 7, 2017
Closed
@jdaguil
Copy link
Contributor Author

jdaguil commented Jul 10, 2017

Merged into develop. Additional package specific attributes were taken care of in #68

@jdaguil jdaguil closed this as completed Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdaguil jdaguil

Labels
DataTables enhancement must have
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
3 participants
@pombredanne @jdaguil @mjherzog