Skip to content

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Jan 17, 2024

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

pombredanne and others added 12 commits December 30, 2023 09:51
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Thanks @DennisClark for adding these.

Reference: #3618
Reported-by: Armijn Hemel @armijnhemel
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Reference: #3565
Reported-by: @pombredanne
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Reference: #3613
Reported-by: @fviernau Frank Viernau
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Reference: #3540
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Reference: #3515
Reference: #3512
Reported-by: @bennati
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Reference: #3488
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Reference: #3491
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
This commit improves a few existing license rules to be more selective
adding either required phrasesz or minimum coverage.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #3491
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
pombredanne and others added 7 commits February 19, 2024 16:07
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
These need to be stricter

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is a rare license and should only be detected when there are
significant matches.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to merge!

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Member Author

Thanks @pombredanne , merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 66d7166 into develop Feb 27, 2024
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the update-license-rules branch February 27, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants